kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1380718362
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -982,23 +987,6 @@ private boolean initWithCommittedOffsetsIfNeeded(Timer
timer) {
}
}
- // This is here temporary as we don't have public access to the
ConsumerConfig in this module.
- public static Map<String, Object> appendDeserializerToConfig(Map<String,
Object> configs,
-
Deserializer<?> keyDeserializer,
-
Deserializer<?> valueDeserializer) {
- // validate deserializer configuration, if the passed deserializer
instance is null, the user must explicitly set a valid deserializer
configuration value
- Map<String, Object> newConfigs = new HashMap<>(configs);
- if (keyDeserializer != null)
- newConfigs.put(KEY_DESERIALIZER_CLASS_CONFIG,
keyDeserializer.getClass());
- else if (newConfigs.get(KEY_DESERIALIZER_CLASS_CONFIG) == null)
- throw new ConfigException(KEY_DESERIALIZER_CLASS_CONFIG, null,
"must be non-null.");
- if (valueDeserializer != null)
- newConfigs.put(VALUE_DESERIALIZER_CLASS_CONFIG,
valueDeserializer.getClass());
- else if (newConfigs.get(VALUE_DESERIALIZER_CLASS_CONFIG) == null)
- throw new ConfigException(VALUE_DESERIALIZER_CLASS_CONFIG, null,
"must be non-null.");
- return newConfigs;
- }
-
Review Comment:
This appears to be outdated. This is not in `ConsumerUtils` but stays in
`ConsumerConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
