junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1380724965
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This method can be used as a callback in a different request
thread. Ensure that correct RequestLocal
+ * is passed when executing this method. Accessing non-thread-safe data
structures should be avoided if possible.
+ */
+ private def appendEntries(allEntries: Map[TopicPartition, MemoryRecords],
+ internalTopicsAllowed: Boolean,
+ origin: AppendOrigin,
+ requiredAcks: Short,
+ verificationGuards: Map[TopicPartition,
VerificationGuard],
Review Comment:
I guess that proposal is that when serving an `OffsetCommit` request,
KafkaAPIs first determines the partitions for txn validation. It then initiates
the txn validation asychnronously. Once the validation is done, it calls
`ReplicaManager.append` w/o further txn validation.
If we do this, I am wondering if we should just do the same for regular
produce requests too. This way, we don't need the callback logic for txn
validation in `ReplicaManager.append`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
