mjsax commented on code in PR #14681:
URL: https://github.com/apache/kafka/pull/14681#discussion_r1381144344
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -618,7 +618,7 @@ public ProducerConfig(Map<String, Object> props) {
super(CONFIG, props);
}
- ProducerConfig(Map<?, ?> props, boolean doLog) {
+ protected ProducerConfig(Map<?, ?> props, boolean doLog) {
Review Comment:
I would be in strong favor of clarifying (or changing) the rules. Requiring
a KIP for a change like this seems to defeat he purpose of the KIP process.
Sophie could do a quick KIP in parallel to unblock this PR if she want, but
to avoid such discussion in the future and to make it simpler to just "do
stuff" that is clearly straightforward, changing/clarifying the rules seems to
be worth the effort.
@ableegoldman do you want to drive a discussion to clarify the rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
