junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1381953916
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This method can be used as a callback in a different request
thread. Ensure that correct RequestLocal
+ * is passed when executing this method. Accessing non-thread-safe data
structures should be avoided if possible.
+ */
+ private def appendEntries(allEntries: Map[TopicPartition, MemoryRecords],
+ internalTopicsAllowed: Boolean,
+ origin: AppendOrigin,
+ requiredAcks: Short,
+ verificationGuards: Map[TopicPartition,
VerificationGuard],
Review Comment:
> I think we also discussed that the ordering of the log is not the
important part but rather committing stale data.
Is it true that the ordering of the log records is not important? It seems
that you want the latest log to reflect the latest state, right?
> I was saying that appendEntries queues up a log record and we could use it
there.
Yes, the only thing is whether appendEntries can queue up the log record in
the right order. I am not sure simply acquiring the group lock when
asynchronously calling appendEntries achieves this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
