philipnee commented on PR #14690: URL: https://github.com/apache/kafka/pull/14690#issuecomment-1793538245
Hi @AndrewJSchofield - Thank you for your inputs here, your point is absolutely valid in terms of the abstraction it provides. My main concern is the rebalance callback invocation. Maybe I misunderstood the PR, but I think the state transition in the whenComplete can be completed by the main thread if the user supplies a callback, unless the callback is not supplied. I will double-check the syntax. Could you be more specific about `using CF to enqueue an event`? Do you mean by enqueuing a callback completion signal to some background thread queue, to notify the thread to perform the subsequent action? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
