lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1383513687
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -172,10 +223,14 @@ private NetworkClientDelegate.UnsentRequest
makeHeartbeatRequest() {
membershipManager.groupInstanceId().ifPresent(data::setInstanceId);
- if (this.subscriptions.hasPatternSubscription()) {
- // TODO: Pass the string to the GC if server side regex is used.
- } else {
- data.setSubscribedTopicNames(new
ArrayList<>(this.subscriptions.subscription()));
+ // Send subscription to the broker only if it has changed
+ if (sendUpdatedSubscription) {
Review Comment:
Done, I updated it back to sending all fields for now. I will follow up in a
next PR to send only what's needed.
I expect that it will be the existing `HeartbeatState` the one to extend, to
be able to build a `ConsumerGroupRequestData` based on the last one sent, the
member info, and the subscription info (determine difference to send only what
changed, and send all on the failed attempts that it already handles for
retry/backoff)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
