jeffkbkim commented on code in PR #14387: URL: https://github.com/apache/kafka/pull/14387#discussion_r1384084418
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ########## @@ -120,6 +121,9 @@ import static org.apache.kafka.coordinator.group.generic.GenericGroupState.EMPTY; import static org.apache.kafka.coordinator.group.generic.GenericGroupState.PREPARING_REBALANCE; import static org.apache.kafka.coordinator.group.generic.GenericGroupState.STABLE; +import static org.apache.kafka.coordinator.group.metrics.GroupCoordinatorMetrics.COMPLETED_REBALANCES_SENSOR_NAME; Review Comment: i agree it's confusing, but not sure if there are alternatives. Would it be better if we rename the sensor variable names at least? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
