linzihao1999 commented on code in PR #14707:
URL: https://github.com/apache/kafka/pull/14707#discussion_r1384872182
##########
core/src/test/scala/unit/kafka/server/KafkaMetricReporterExceptionHandlingTest.scala:
##########
@@ -50,19 +52,30 @@ class KafkaMetricReporterExceptionHandlingTest extends
BaseRequestTest {
// need a quota prop to register a "throttle-time" metrics after server
startup
val quotaProps = new Properties()
quotaProps.put(QuotaConfigs.REQUEST_PERCENTAGE_OVERRIDE_CONFIG, "0.1")
- adminZkClient.changeClientIdConfig("<default>", quotaProps)
+
+ if (isKRaftTest()) {
+ val admin = createAdminClient()
Review Comment:
I think it no need to. `admin` will close via
IntegrationTestHarness.teardown().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
