jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1385453402
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -562,6 +562,26 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class LeaderNode(leaderId: Int, leaderEpoch: Int, node: Node)
+
+ private def getCurrentLeader(tp: TopicPartition, ln: ListenerName):
LeaderNode = {
+ val partitionInfoOrError = replicaManager.getPartitionOrError(tp)
Review Comment:
I think it would be useful to have to see that the -1 -1 is handled as
expected. Maybe you can mock the metadata cache as well? Change it to only
return the data once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
