jolshan opened a new pull request, #14712: URL: https://github.com/apache/kafka/pull/14712
With the new callback mechanism we were accidentally passing context with the wrong request local. Now include a RequestLocal as an explicit argument to the callback. Also make the arguments passed through the callback clearer by separating the method out. Added a test to ensure we use the request handler's request local and not the one passed in when the callback is executed via the request handler. Reviewers: Ismael Juma <[email protected]>, Divij Vaidya <[email protected]>, David Jacot <[email protected]>, Jason Gustafson <[email protected]>, Artem Livshits <[email protected]>, Jun Rao <[email protected]>, Conflicts: core/src/main/scala/kafka/server/KafkaRequestHandler.scala core/src/main/scala/kafka/server/ReplicaManager.scala core/src/test/scala/kafka/server/KafkaRequestHandlerTest.scala Conflicts around verification guard, running the callback on the same thread, and checking the coordinator node before AddPartitionsToTxnManager, so I wanted to run the tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
