mjsax commented on code in PR #14596: URL: https://github.com/apache/kafka/pull/14596#discussion_r1387469522
########## streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java: ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.integration; + +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.empty; +import static org.hamcrest.Matchers.is; + +import java.time.Duration; +import java.time.Instant; +import java.util.Collections; +import java.util.Optional; +import java.util.Properties; +import org.apache.kafka.clients.producer.KafkaProducer; +import org.apache.kafka.clients.producer.ProducerConfig; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.apache.kafka.common.serialization.IntegerSerializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.utils.Utils; +import org.apache.kafka.streams.KafkaStreams; +import org.apache.kafka.streams.StreamsBuilder; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.integration.utils.EmbeddedKafkaCluster; +import org.apache.kafka.streams.kstream.Materialized; +import org.apache.kafka.streams.query.QueryResult; +import org.apache.kafka.streams.query.StateQueryRequest; +import org.apache.kafka.streams.query.StateQueryResult; +import org.apache.kafka.streams.query.VersionedKeyQuery; +import org.apache.kafka.streams.state.Stores; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.IntegrationTest; +import org.junit.After; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +@Category({IntegrationTest.class}) +public class IQv2VersionedStoreIntegrationTest { + private static final int NUM_BROKERS = 1; + private static final String INPUT_TOPIC_NAME = "input-topic"; + private static final String STORE_NAME = "versioned-store"; + private static final Duration HISTORY_RETENTION = Duration.ofDays(1); + private static final Instant BASE_TIMESTAMP = Instant.parse("2023-01-01T10:00:00.00Z"); + private static final Long RECORD_TIMESTAMP_OLD = BASE_TIMESTAMP.toEpochMilli(); + private static final Long RECORD_TIMESTAMP_NEW = RECORD_TIMESTAMP_OLD + 100; + private static final int RECORD_KEY = 2; + private static final int RECORD_VALUE_OLD = 2; + private static final int RECORD_VALUE_NEW = 3; + + public static final EmbeddedKafkaCluster CLUSTER = new EmbeddedKafkaCluster(NUM_BROKERS, + Utils.mkProperties(Collections.singletonMap("auto.create.topics.enable", "true"))); + private KafkaStreams kafkaStreams; + + @BeforeClass + public static void before() throws Exception { + CLUSTER.start(); + final Properties producerProps = new Properties(); + producerProps.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, CLUSTER.bootstrapServers()); + producerProps.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, IntegerSerializer.class); + producerProps.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, IntegerSerializer.class); + final KafkaProducer<Integer, Integer> producer = new KafkaProducer<>(producerProps); + producer.send(new ProducerRecord<>(INPUT_TOPIC_NAME, 0, RECORD_TIMESTAMP_OLD, RECORD_KEY, RECORD_VALUE_OLD)).get(); + producer.send(new ProducerRecord<>(INPUT_TOPIC_NAME, 0, RECORD_TIMESTAMP_NEW, RECORD_KEY, RECORD_VALUE_NEW)).get(); + } + + @Before + public void beforeTest() throws InterruptedException { + final StreamsBuilder builder = new StreamsBuilder(); + builder.table(INPUT_TOPIC_NAME, + Materialized.as(Stores.persistentVersionedKeyValueStore(STORE_NAME, HISTORY_RETENTION))); + final Properties configs = new Properties(); + configs.put(StreamsConfig.APPLICATION_ID_CONFIG, "app"); + configs.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, CLUSTER.bootstrapServers()); + configs.put(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, Serdes.IntegerSerde.class.getName()); + configs.put(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.IntegerSerde.class.getName()); + kafkaStreams = new KafkaStreams(builder.build(), configs); + kafkaStreams.start(); + Thread.sleep(2000); + } + + @After + public void afterTest() { + if (kafkaStreams != null) { + kafkaStreams.close(); + kafkaStreams.cleanUp(); + } + } + + @AfterClass + public static void after() { + CLUSTER.stop(); + } + + @Test + public void verifyStore() { + // retrieve the latest value + shouldHandleVersionedKeyQuery(RECORD_KEY, Optional.empty(), RECORD_VALUE_NEW, RECORD_TIMESTAMP_NEW); + shouldHandleVersionedKeyQuery(RECORD_KEY, Optional.of(Instant.now()), RECORD_VALUE_NEW, RECORD_TIMESTAMP_NEW); + shouldHandleVersionedKeyQuery(RECORD_KEY, Optional.of(Instant.ofEpochMilli(RECORD_TIMESTAMP_NEW)), RECORD_VALUE_NEW, RECORD_TIMESTAMP_NEW); + // retrieve the old value + shouldHandleVersionedKeyQuery(RECORD_KEY, Optional.of(Instant.ofEpochMilli(RECORD_TIMESTAMP_OLD)), RECORD_VALUE_OLD, RECORD_TIMESTAMP_OLD); + // there is no record for the provided timestamp + shouldVerifyGetNull(RECORD_KEY, Instant.ofEpochMilli(RECORD_TIMESTAMP_OLD - 50)); + // there is no record with this key + shouldVerifyGetNull(3, Instant.now()); + } + + private void shouldHandleVersionedKeyQuery(final Integer key, + final Optional<Instant> queryTimestamp, + final Integer expectedValue, + final Long expectedTimestamp) { + + VersionedKeyQuery<Integer, Integer> query = VersionedKeyQuery.withKey(key); + if (queryTimestamp.isPresent()) { + query = query.asOf(queryTimestamp.get()); + } + final StateQueryRequest<VersionedRecord<Integer>> request = StateQueryRequest.inStore(STORE_NAME).withQuery(query); + final StateQueryResult<VersionedRecord<Integer>> result = kafkaStreams.query(request); + + if (result.getOnlyPartitionResult() == null) { + throw new AssertionError("The query returned null."); + } + final QueryResult<VersionedRecord<Integer>> queryResult = result.getOnlyPartitionResult(); + if (queryResult.isFailure()) { + throw new AssertionError(queryResult.toString()); + } + if (queryResult.getResult() == null) { + throw new AssertionError("The query returned null."); + } + + assertThat(queryResult.isSuccess(), is(true)); + final VersionedRecord<Integer> result1 = queryResult.getResult(); + assertThat(result1.value(), is(expectedValue)); + assertThat(result1.timestamp(), is(expectedTimestamp)); + assertThat(queryResult.getExecutionInfo(), is(empty())); } Review Comment: nit: `}` should go to next line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
