agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1393203579
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Materialized.java:
##########
@@ -97,21 +128,21 @@ protected Materialized(final Materialized<K, V, S>
materialized) {
this.cachingEnabled = materialized.cachingEnabled;
this.topicConfig = materialized.topicConfig;
this.retention = materialized.retention;
- this.storeType = materialized.storeType;
+ this.storeSuppliers = materialized.storeSuppliers;
}
/**
- * Materialize a {@link StateStore} with the given {@link StoreType}.
+ * Materialize a {@link StateStore} with the given {@link
DslStoreSuppliers}.
*
- * @param storeType the type of the state store
- * @param <K> key type of the store
- * @param <V> value type of the store
- * @param <S> type of the {@link StateStore}
+ * @param storeSuppliers the type of the state store
+ * @param <K> key type of the store
+ * @param <V> value type of the store
+ * @param <S> type of the {@link StateStore}
* @return a new {@link Materialized} instance with the given storeName
*/
- public static <K, V, S extends StateStore> Materialized<K, V, S> as(final
StoreType storeType) {
- Objects.requireNonNull(storeType, "store type can't be null");
- return new Materialized<>(storeType);
+ public static <K, V, S extends StateStore> Materialized<K, V, S> as(final
DslStoreSuppliers storeSuppliers) {
Review Comment:
yup!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
