AndrewJSchofield commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1394744738
##########
core/src/main/java/kafka/metrics/ClientMetricsConfigs.java:
##########
@@ -80,6 +82,11 @@ public class ClientMetricsConfigs {
public static final String CLIENT_SOURCE_ADDRESS = "client_source_address";
public static final String CLIENT_SOURCE_PORT = "client_source_port";
+ // Empty string in client-metrics resource configs indicates that all the
metrics are subscribed.
+ public static final String ALL_SUBSCRIBED_METRICS_CONFIG = "\"\"";
Review Comment:
It would be possible to change the KIP to support a list containing just `*`
to mean all metrics. The KIP today says a list containing just `""` means all
metrics. That's a pretty simple change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
