artemlivshits commented on code in PR #14731:
URL: https://github.com/apache/kafka/pull/14731#discussion_r1394891315
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##########
@@ -327,6 +328,7 @@ class TransactionStateManager(brokerId: Int,
}
def shouldInclude(txnMetadata: TransactionMetadata): Boolean = {
+ val now : Long = System.currentTimeMillis()
Review Comment:
Can we move this outside of the callback so that all transactions would be
checked against the same timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
