jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1395060812
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -469,19 +469,35 @@ class GroupMetadataManager(brokerId: Int,
responseCallback(commitStatus)
}
- if (isTxnOffsetCommit) {
- group.inLock {
- addProducerGroup(producerId, group.groupId)
- group.prepareTxnOffsetCommit(producerId, offsetMetadata)
+ val transactionVerificationEntries = new
ReplicaManager.TransactionVerificationEntries
+ def postVerificationCallback(newRequestLocal: RequestLocal)
+ (newlyVerifiedEntries:
Map[TopicPartition, MemoryRecords], errorResults: Map[TopicPartition,
LogAppendResult]): Unit = {
+
+ if (isTxnOffsetCommit) {
Review Comment:
placeholder for the locking/checks we need for offset commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
