yashmayya commented on PR #14762: URL: https://github.com/apache/kafka/pull/14762#issuecomment-1814288871
> Since other workers in the cluster may not have this fix applied, I'll leave the error message unchanged and just update the assertions. Hm, the original purpose of those tests were to verify that the admin client error handling [here](https://github.com/apache/kafka/blob/e7f4f5dfe7ef2c95f3e9a1dbbeded8502d3e1e05/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java#L1427-L1438) and [here](https://github.com/apache/kafka/blob/e7f4f5dfe7ef2c95f3e9a1dbbeded8502d3e1e05/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java#L1470-L1481) is correct and to safeguard against any regressions (from unexpected changes in the admin client or consumer group coordinator for instance) in that path. Considering that, these assertion changes defeat the purpose of those tests. Perhaps we could bump up the value for the `task.shutdown.graceful.timeout.ms` worker config (which would delay the task cancellation) in those particular tests in order to retain the original intent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
