[ 
https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786768#comment-17786768
 ] 

Kamal Chandraprakash edited comment on KAFKA-14877 at 11/16/23 2:20 PM:
------------------------------------------------------------------------

[~showuon] [~divijvaidya] 

The task expectation is not clear from the discussion. Do we want to avoid the 
creation of intermediary LeaderEpochFileCache instance? (by adding couple of 
methods: `truncateFromStart` and `truncateFromEnd` on the 
InMemoryLeaderEpochCheckpoint class)

Since the InMemoryLeaderEpochCheckpoint stores the data in memory, there is 
almost negligible cost in doing the `flush`.


was (Author: ckamal):
[~showuon] [~divijvaidya] 

The task expectation is not clear from the discussion. Do we want to avoid the 
creation of intermediary LeaderEpochFileCache instance? (by adding couple of 
methods: `truncateFromStart` and `truncateFromEnd on the 
InMemoryLeaderEpochCheckpoint class)

Since the InMemoryLeaderEpochCheckpoint stores the data in memory, there is 
almost negligible cost in doing the `flush`.

> refactor InMemoryLeaderEpochCheckpoint
> --------------------------------------
>
>                 Key: KAFKA-14877
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14877
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Luke Chen
>            Assignee: Kamal Chandraprakash
>            Priority: Minor
>             Fix For: 3.7.0
>
>
> follow up with this comment: 
> https://github.com/apache/kafka/pull/13456#discussion_r1154306477



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to