cmccabe commented on PR #14369: URL: https://github.com/apache/kafka/pull/14369#issuecomment-1815518652
> @cmccabe I'm confused, I thought that was the whole point of kafka.utils.Exit https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/utils/Exit.scala#L21-L24 https://github.com/apache/kafka/blob/00e5803cd3af89011254e734232308618403309d/clients/src/test/java/org/apache/kafka/common/utils/ExitTest.java > > The FaultHandler concept in QuorumController seems great, but I'm not sure how it fits here: afaict the fault is always fatal and we can intercept it in tests - what am I missing? Exit has two very big flaws: 1. it uses static variables, so if you run tests in parallel, you can hit issues. 2. you have to remember to set it. most tests leave Exit's default behavior intact (which is exiting the process) Anyway we can talk more about this later. We don't have to convert to using it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
