ableegoldman commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1815619664
> do we need this pausing semantics for ReadOnlyTask as well? Alright so I'm not super familiar with this new code which seems to be related to the state updater, but IIUC the ReadOnlyTask is like a kind of StreamTask that is still in restoration and should not be processed/operated on/written to by the StreamThread -- it's "read only" presumably for IQ which might need to read a restoring task when stale reads are enabled. Given that, I would conclude that no, we don't need pausing semantics, if anything these tasks are effectively already paused. They don't really even have an input buffer for us to pause. @vamossagar12 I think we should try to avoid casting anyways, we don't want to deal with this breaking any time a new task type is added. Looks like we were just doing this to invoke the new `StreamTask#totalBytesBuffered` method, so how about we move that method to the `Task` interface and just return 0 for the implementation of it in ReadOnlyTask and StandbyTask? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
