cadonna commented on PR #14779: URL: https://github.com/apache/kafka/pull/14779#issuecomment-1815989094
I agree with @philipnee that testing the locking behavior would be great. However, I also agree with @lucasbru that testing the locking behavior is quite hard. Given the tight deadline to the next release, I propose to create a newbie ticket for testing the blocking behavior and do that in a follow-up PR. Said that, I think some methods might be testable without any additional tooling. For example, `poll()` can be blocked waiting for the fetches in the fetch buffer and then be unblocked once the locking is verified. I do not know if we can do similar for other public methods. In any case, I think we should make a compromise and merge this PR w/o specific tests and do the testing in a follow-up PR (Note: you will not hear/read this sentence often from me). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
