cadonna commented on PR #14746: URL: https://github.com/apache/kafka/pull/14746#issuecomment-1816005251
> I wonder if we could just use a BlockingQueue for the fetchBuffer because fetchBuffer.poll(time) blocks until non-empty or timeout. As far as I see from the javadocs of a `BlockingQueue` there is no way to wake up from `poll()` other than interrupting the thread. I think signalling on a condition variable is safer than interrupting a thread since its scope is well-defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
