[jira] [Commented] (KAFKA-7039) DelegatingClassLoader creates plugin instance even if its not Versioned

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KAFKA-7039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514995#comment-16514995
 ] 

ASF GitHub Bot commented on KAFKA-7039:
---------------------------------------

ewencp closed pull request #5191: KAFKA-7039 : Create an instance of the plugin 
only it's a Versioned Plugin
URL: https://github.com/apache/kafka/pull/5191
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
 
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
index dd387c45f52..144dbd87f55 100644
--- 
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
+++ 
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
@@ -62,6 +62,7 @@
 public class DelegatingClassLoader extends URLClassLoader {
     private static final Logger log = 
LoggerFactory.getLogger(DelegatingClassLoader.class);
     private static final String CLASSPATH_NAME = "classpath";
+    private static final String UNDEFINED_VERSION = "undefined";
 
     private final Map<String, SortedMap<PluginDesc<?>, ClassLoader>> 
pluginLoaders;
     private final Map<String, String> aliases;
@@ -318,7 +319,7 @@ private PluginScanResult scanPluginPath(
         Collection<PluginDesc<T>> result = new ArrayList<>();
         for (Class<? extends T> plugin : plugins) {
             if (PluginUtils.isConcrete(plugin)) {
-                result.add(new PluginDesc<>(plugin, 
versionFor(plugin.newInstance()), loader));
+                result.add(new PluginDesc<>(plugin, versionFor(plugin), 
loader));
             } else {
                 log.debug("Skipping {} as it is not concrete implementation", 
plugin);
             }
@@ -336,7 +337,12 @@ private PluginScanResult scanPluginPath(
     }
 
     private static <T>  String versionFor(T pluginImpl) {
-        return pluginImpl instanceof Versioned ? ((Versioned) 
pluginImpl).version() : "undefined";
+        return pluginImpl instanceof Versioned ? ((Versioned) 
pluginImpl).version() : UNDEFINED_VERSION;
+    }
+
+    private static <T> String versionFor(Class<? extends T> pluginKlass) 
throws IllegalAccessException, InstantiationException {
+        // Temporary workaround until all the plugins are versioned.
+        return Connector.class.isAssignableFrom(pluginKlass) ? 
versionFor(pluginKlass.newInstance()) : UNDEFINED_VERSION;
     }
 
     @Override


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DelegatingClassLoader creates plugin instance even if its not Versioned
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-7039
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7039
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 2.0.0
>            Reporter: Magesh kumar Nandakumar
>            Assignee: Magesh kumar Nandakumar
>            Priority: Blocker
>             Fix For: 2.0.0, 2.1.0
>
>
> The versioned interface was introduced as part of 
> [KIP-285|https://cwiki.apache.org/confluence/display/KAFKA/KIP-285%3A+Connect+Rest+Extension+Plugin].
>  DelegatingClassLoader is now attempting to create an instance of all the 
> plugins, even if it's not required.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)