junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397714746
##########
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##########
@@ -60,17 +62,47 @@ public PushTelemetryRequest(PushTelemetryRequestData data,
short version) {
@Override
public PushTelemetryResponse getErrorResponse(int throttleTimeMs,
Throwable e) {
- PushTelemetryResponseData responseData = new
PushTelemetryResponseData()
- .setErrorCode(Errors.forException(e).code())
- .setThrottleTimeMs(throttleTimeMs);
- return new PushTelemetryResponse(responseData);
+ return errorResponse(throttleTimeMs, Errors.forException(e));
}
@Override
public PushTelemetryRequestData data() {
return data;
}
+ public PushTelemetryResponse errorResponse(int throttleTimeMs, Errors
errors) {
+ PushTelemetryResponseData responseData = new
PushTelemetryResponseData();
+ responseData.setErrorCode(errors.code());
+ /*
+ THROTTLING_QUOTA_EXCEEDED is thrown in telemetry APIs when the
telemetry request
+ arrives prior the configured minimum interval between two consecutive
telemetry requests.
+ In this case, the throttleTimeMs should not be included in the
response to avoid the
+ muting of the client channel for all the other requests.
+ */
+ if (Errors.THROTTLING_QUOTA_EXCEEDED != errors) {
Review Comment:
We shouldn't set throttleTimeMs even for Errors.THROTTLING_QUOTA_EXCEEDED.
throttleTimeMs can only be set when there is no error.
##########
core/src/main/java/kafka/metrics/ClientMetricsReceiverPlugin.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package kafka.metrics;
+
+import org.apache.kafka.common.requests.PushTelemetryRequest;
+import org.apache.kafka.common.requests.RequestContext;
+import org.apache.kafka.server.telemetry.ClientTelemetryReceiver;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Plugin to register client telemetry receivers and export metrics. This
class is used by the Kafka
+ * server to export client metrics to the registered receivers.
+ */
+public class ClientMetricsReceiverPlugin {
+
+ private static final ClientMetricsReceiverPlugin INSTANCE = new
ClientMetricsReceiverPlugin();
Review Comment:
Hmm, why is ClientMetricsManager needed in the controller? I thought only
brokers can receive get/push telemetric requests.
##########
core/src/test/java/kafka/metrics/ClientMetricsInstanceTest.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package kafka.metrics;
+
+import org.apache.kafka.common.Uuid;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.net.UnknownHostException;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class ClientMetricsInstanceTest {
+
+ private Uuid uuid;
+ private ClientMetricsInstanceMetadata instanceMetadata;
+ private ClientMetricsInstance clientInstance;
+
+ @BeforeEach
+ public void setUp() throws UnknownHostException {
+ uuid = Uuid.randomUuid();
+ instanceMetadata = new ClientMetricsInstanceMetadata(uuid,
+ ClientMetricsTestUtils.requestContext());
+ clientInstance = new ClientMetricsInstance(Uuid.randomUuid(),
instanceMetadata, 0, 0,
+ null, ClientMetricsConfigs.DEFAULT_INTERVAL_MS);
+ }
+
+ @Test
+ public void testMaybeUpdateRequestEpochValid() {
+ // First request should be accepted.
+
assertTrue(clientInstance.maybeUpdateGetRequestEpoch(System.currentTimeMillis()));
Review Comment:
Could we use MockTime instead of System time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
