divijvaidya commented on code in PR #14796:
URL: https://github.com/apache/kafka/pull/14796#discussion_r1398332350
##########
build.gradle:
##########
@@ -842,6 +842,62 @@ tasks.create(name: "jarConnect", dependsOn:
connectPkgs.collect { it + ":jar" })
tasks.create(name: "testConnect", dependsOn: connectPkgs.collect { it +
":test" }) {}
+project(':server') {
+ archivesBaseName = "kafka-server"
+
+ dependencies {
+ implementation project(':clients')
+ implementation project(':server-common')
+
+ implementation libs.slf4jApi
+
+ compileOnly libs.log4j
+
+ testImplementation project(':clients').sourceSets.test.output
+
+ testImplementation libs.mockitoCore
+ testImplementation libs.junitJupiter
+ testImplementation libs.slf4jlog4j
+ }
+
+ task createVersionFile() {
Review Comment:
this is duplicated across all projects. Could we extract it out and use the
same task across all sub-projects?
##########
build.gradle:
##########
@@ -842,6 +842,62 @@ tasks.create(name: "jarConnect", dependsOn:
connectPkgs.collect { it + ":jar" })
tasks.create(name: "testConnect", dependsOn: connectPkgs.collect { it +
":test" }) {}
+project(':server') {
+ archivesBaseName = "kafka-server"
+
+ dependencies {
+ implementation project(':clients')
+ implementation project(':server-common')
+
+ implementation libs.slf4jApi
+
+ compileOnly libs.log4j
+
+ testImplementation project(':clients').sourceSets.test.output
+
+ testImplementation libs.mockitoCore
+ testImplementation libs.junitJupiter
+ testImplementation libs.slf4jlog4j
+ }
+
+ task createVersionFile() {
+ def receiptFile = file("$buildDir/kafka/$buildVersionFileName")
Review Comment:
am not a gradle expert but my IDE is telling me that $buildDir is deprecated
and replaced by `getLayout().getBuildDirectory()` instead
##########
build.gradle:
##########
@@ -1643,19 +1700,6 @@ project(':server-common') {
}
}
- sourceSets {
- main {
- java {
- srcDirs = ["src/main/java"]
- }
- }
- test {
- java {
- srcDirs = ["src/test/java"]
- }
- }
- }
Review Comment:
Should we create a ticket to get rid of this from all sub-projects? If you
like, we can do it as part of this PR itself.
##########
checkstyle/import-control-storage.xml:
##########
@@ -27,15 +27,11 @@
<allow pkg="javax.management" />
<allow pkg="org.slf4j" />
<allow pkg="org.junit" />
- <allow pkg="org.opentest4j" />
<allow pkg="org.hamcrest" />
<allow pkg="org.mockito" />
- <allow pkg="org.easymock" />
- <allow pkg="org.powermock" />
<allow pkg="java.security" />
<allow pkg="javax.net.ssl" />
<allow pkg="javax.security" />
- <allow pkg="org.ietf.jgss" />
Review Comment:
thank you for cleaning the import-control files!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
