kamalcph commented on PR #14136: URL: https://github.com/apache/kafka/pull/14136#issuecomment-1818250640
> RLM#onLeadershipChange, we did use metadataCache, so we should make sure metadataCache comes first before LISR. Had another look, we can still pass the topicIDs into RLM#onLeadershipChange to bypass it. So it looks fine. We are still using metadata-cache in RLM#onLeadershipChange, we have to ensure that the `MetadataCache` is updated before handling the LeaderAndIsrRequest (LISR). Otherwise, we can follow the suggestion posted by @showuon. Also, there are existing test failures related to remote storage, can you please take a look? ``` Build / JDK 11 and Scala 2.13 / executeTieredStorageTest(String).quorum=kraft – org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest Build / JDK 11 and Scala 2.13 / testSendOffsetsWithGroupMetadata(String).quorum=kraft – org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest Build / JDK 11 and Scala 2.13 / testBasicTransactions(String).quorum=kraft – org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest Build / JDK 11 and Scala 2.13 / testSendOffsetsWithGroupId(String).quorum=kraft – org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest Build / JDK 11 and Scala 2.13 / testDelayedFetchIncludesAbortedTransaction(String).quorum=kraft – org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest Build / JDK 21 and Scala 2.13 / testAbortTransactionTimeout(String).quorum=kraft – org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
