OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399564930
##########
core/src/main/java/kafka/server/AssignmentsManager.java:
##########
@@ -210,6 +220,9 @@ public void run() throws Exception {
channelManager.sendRequest(new AssignReplicasToDirsRequest.Builder(
buildRequestData(brokerId, brokerEpochSupplier.get(),
assignment)),
new AssignReplicasToDirsRequestCompletionHandler());
+ inflight.values().stream()
+ .filter(assignmentEvent -> assignmentEvent.callback !=
null)
+ .forEach(assignmentEvent ->
assignmentEvent.callback.accept(DirectoryEventRequestState.DISPATCHED));
Review Comment:
For dispatched this is true but for queued I think we still need this so we
don't send the reassignment multiple times to AssignmentManager. Especially
that as far as I see the manager isn't idempotent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
