dajac commented on code in PR #14781:
URL: https://github.com/apache/kafka/pull/14781#discussion_r1401788044
##########
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##########
@@ -67,6 +67,10 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness {
if (isZkMigrationTest()) {
cfgs.foreach(_.setProperty(KafkaConfig.MigrationEnabledProp, "true"))
}
+ if (isNewGroupCoordinatorEnabled()) {
+ cfgs.foreach(_.setProperty(KafkaConfig.UnstableApiVersionsEnableProp,
"true"))
Review Comment:
We could actually remove this now that
https://github.com/apache/kafka/commit/7826d5fc8ab695a5ad927338469ddc01b435a298
was merged.
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##########
@@ -547,23 +564,29 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEquals(2, parts.size)
}
- @Test
- def testPartitionsForAutoCreate(): Unit = {
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft", "kraft+kip848"))
+ def testPartitionsForAutoCreate(quorum: String): Unit = {
val consumer = createConsumer()
// First call would create the topic
consumer.partitionsFor("non-exist-topic")
- val partitions = consumer.partitionsFor("non-exist-topic")
- assertFalse(partitions.isEmpty)
+ var partitions = consumer.partitionsFor("non-exist-topic")
+ TestUtils.waitUntilTrue(() => {
+ partitions = consumer.partitionsFor("non-exist-topic")
+ !partitions.isEmpty
+ }, s"Timed out while awaiting non empty partitions.")
Review Comment:
nit: We don't really need `var partitions` here. How about?
```
TestUtils.waitUntilTrue(() => {
!consumer.partitionsFor("non-exist-topic").isEmpty
}, s"Timed out while awaiting non empty partitions.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
