yashmayya opened a new pull request, #14825: URL: https://github.com/apache/kafka/pull/14825
- https://issues.apache.org/jira/browse/KAFKA-15888 - By default, if there is no `client.id` configured on a Connect worker running in distributed mode, the same client ID (`connect-1`) will be used in the log context for the `DistributedHerder` class in every single worker in the Connect cluster. - This default is quite confusing and obviously not very useful. - Further, based on how this default is configured - https://github.com/apache/kafka/blob/150b0e8290cda57df668ba89f6b422719866de5a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java#L299 it seems like this might have been an unintentional bug (the static `AtomicInteger` is incremented in the `DistributedHerder`'s constructor, but we're only going to initialize a single `DistributedHerder` per worker JVM process). - This patch changes the default to simply use the `workerId` (the advertised host name and port of the worker) instead, which should be unique for each worker in a cluster. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
