AndrewJSchofield commented on code in PR #14758:
URL: https://github.com/apache/kafka/pull/14758#discussion_r1403092072
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##########
@@ -277,8 +294,10 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEquals(500,
anotherConsumer.committed(Set(tp2).asJava).get(tp2).offset)
}
- @Test
- def testAutoCommitOnCloseAfterWakeup(): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("generic")) // close() is not committing
offsets in consumer group protocol
Review Comment:
I agree with the idea, but I will use a less wordy formulation such as
"temporarily". I expect a bunch of these will be resolved in the next two weeks
and we can run most of the tests across both consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
