apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1405881343
########## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryEmitter.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients; + +import org.apache.kafka.common.telemetry.internals.MetricKeyable; +import org.apache.kafka.common.telemetry.internals.MetricsEmitter; +import org.apache.kafka.common.telemetry.internals.SinglePointMetric; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.function.Predicate; + +public class ClientTelemetryEmitter implements MetricsEmitter { + + private final Predicate<? super MetricKeyable> selector; + private final List<SinglePointMetric> emitted; + private final boolean deltaMetrics; + + public ClientTelemetryEmitter(Predicate<? super MetricKeyable> selector, boolean deltaMetrics) { + this.selector = selector; + this.emitted = new ArrayList<>(); Review Comment: Thanks for pointing put @mjsax. I earlier thought to make this class stateless but realized it actually depends on the usage. Currently the way we export metrics from the client is dependent on NetworkClient as that manages the data transmission to broker. But we can have potentially another implementation of MetricsEmitter to emit metrics directly to some external system i.e. say directly to any local opentelemetry client. I have updated the docs comment on `MetricsEmitter`. Please let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
