gharris1727 commented on PR #14763: URL: https://github.com/apache/kafka/pull/14763#issuecomment-1828397516
> Also, is it worth adding a test (or augmenting one or more existing test cases) for this? I added a test to KafkaBasedLogTest, but found that it was difficult to set up the same test for the duplicate implementation in OffsetSyncStore. Instead, I eliminated the OffsetSyncStore implementation, because i felt it duplicated the withExistingClients method, and this resource leak. I think we had some discussion about why adding a new constructor to KafkaBasedLog was not viable, but would you consider changing the signature of the withExistingClients method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
