philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406788484
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -184,7 +184,7 @@ private static long findMinTime(final Collection<? extends
RequestState> request
* completed future if no request is generated.
*/
public CompletableFuture<Void> maybeAutoCommit(final Map<TopicPartition,
OffsetAndMetadata> offsets) {
- if (!autoCommitState.isPresent()) {
+ if (!canAutoCommit()) {
Review Comment:
pretty terrible naming because it kind of overlaps with the one below, not
sure there's a better description for it. It needs to check 1. if autocommit
is enabled and 2. if there's anything to commit. If neither, then we don't try
to send a commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
