showuon commented on code in PR #14840:
URL: https://github.com/apache/kafka/pull/14840#discussion_r1407350742
##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##########
@@ -70,18 +70,20 @@ public TopicBasedRemoteLogMetadataManager topicBasedRlmm() {
}
@Test
- public void testInternalTopicExists() {
+ public void testDoesTopicExist() {
Properties adminConfig =
remoteLogMetadataManagerHarness.adminClientConfig();
ListenerName listenerName =
remoteLogMetadataManagerHarness.listenerName();
try (Admin admin =
remoteLogMetadataManagerHarness.createAdminClient(listenerName, adminConfig)) {
- String topic =
topicBasedRlmm().config().remoteLogMetadataTopicName();
+ String topic = "test-topic-exist";
+ remoteLogMetadataManagerHarness.createTopic(topic, 1, 1, new
Properties(),
Review Comment:
Yes, you're right, we'll make sure the metadata is propagated to all nodes
for both KRaft and ZK modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
