jolshan commented on code in PR #14844:
URL: https://github.com/apache/kafka/pull/14844#discussion_r1408586225
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##########
@@ -590,12 +590,18 @@ private ApiMessage messageOrNull(ApiMessageAndVersion
apiMessageAndVersion) {
/**
* Replays the Record to update the hard state of the group coordinator.
-
- * @param record The record to apply to the state machine.
+ *
+ * @param producerId The producer id.
+ * @param producerEpoch The producer epoch.
+ * @param record The record to apply to the state machine.
* @throws RuntimeException
*/
@Override
- public void replay(Record record) throws RuntimeException {
+ public void replay(
+ long producerId,
Review Comment:
Is the idea here that we pass in the id and the epoch to the relevant
records when we implement the offset commit code that can handle them? (But
that part is to be implemented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
