dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1408975349
##########
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##########
@@ -239,10 +240,8 @@ public static String safeUniqueTestName(final Class<?>
testClass, final TestName
* Used by tests migrated to JUnit 5.
*/
public static String safeUniqueTestName(final Class<?> testClass, final
TestInfo testInfo) {
- final String displayName = testInfo.getDisplayName();
final String methodName =
testInfo.getTestMethod().map(Method::getName).orElse("unknownMethodName");
- final String testName = displayName.contains(methodName) ? methodName
: methodName + displayName;
- return safeUniqueTestName(testClass, testName);
+ return safeUniqueTestName(testClass, methodName + "_" +
Uuid.randomUuid().toString());
Review Comment:
With the current method, we end up with a non-unique name for the
parameterized tests. Therefore, I suggest to just use the name of the method
with a uuid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
