mjsax commented on code in PR #14864:
URL: https://github.com/apache/kafka/pull/14864#discussion_r1410260721
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##########
@@ -454,4 +480,19 @@ public void shutdown() {
public Map<MetricName, Metric> consumerMetrics() {
return Collections.unmodifiableMap(globalConsumer.metrics());
}
+
+ public KafkaFuture<Uuid> globalConsumerInstanceId(final Duration timeout) {
Review Comment:
Frankly, given that `fetchDeadline` might be modified (and pushed into the
future) by a second call to `KafkaStreams#clientInstanceIds(...)` while the
first was not completed yet, it seems we would need `synchronized` in addition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
