dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1411872217
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -322,16 +314,14 @@ private void onErrorResponse(final
ConsumerGroupHeartbeatResponse response,
break;
case FENCED_MEMBER_EPOCH:
- message = String.format("GroupHeartbeatRequest failed because
member ID %s with epoch %s is invalid. " +
- "Will abandon all partitions and rejoin the
group",
+ message = String.format("GroupHeartbeatRequest failed because
member ID %s with epoch %s is invalid.",
membershipManager.memberId(),
membershipManager.memberEpoch());
logInfo(message, response, currentTimeMs);
membershipManager.transitionToFenced();
break;
case UNKNOWN_MEMBER_ID:
- message = String.format("GroupHeartbeatRequest failed because
member of unknown ID %s with epoch %s is invalid. " +
- "Will abandon all partitions and rejoin the
group",
+ message = String.format("GroupHeartbeatRequest failed because
member of unknown ID %s with epoch %s is invalid.",
Review Comment:
nit: How about `GroupHeartbeatRequest failed because member id {} is
unknown.`?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -322,16 +314,14 @@ private void onErrorResponse(final
ConsumerGroupHeartbeatResponse response,
break;
case FENCED_MEMBER_EPOCH:
- message = String.format("GroupHeartbeatRequest failed because
member ID %s with epoch %s is invalid. " +
- "Will abandon all partitions and rejoin the
group",
+ message = String.format("GroupHeartbeatRequest failed because
member ID %s with epoch %s is invalid.",
Review Comment:
nit: While we are here, how about `GroupHeartbeatRequest failed because
epoch {} is fenced.`?.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
