dajac commented on code in PR #14913:
URL: https://github.com/apache/kafka/pull/14913#discussion_r1413920570
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -78,13 +78,11 @@ public ConsumerNetworkThread(LogContext logContext,
this.applicationEventProcessorSupplier =
applicationEventProcessorSupplier;
this.networkClientDelegateSupplier = networkClientDelegateSupplier;
this.requestManagersSupplier = requestManagersSupplier;
+ this.running = true;
}
@Override
public void run() {
- closer.assertOpen("Consumer network thread is already closed");
Review Comment:
This assertion does not seem really helpful. It seems better to me to only
rely on `running`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
