dajac commented on code in PR #14870:
URL: https://github.com/apache/kafka/pull/14870#discussion_r1414399614
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##########
@@ -524,17 +524,16 @@ public CoordinatorResult<OffsetDeleteResponseData,
Record> deleteOffsets(
* @return The list of tombstones (offset commit and group metadata) to
append.
*/
public CoordinatorResult<Void, Record> cleanupGroupMetadata() {
+ long startMs = time.milliseconds();
List<Record> records = new ArrayList<>();
groupMetadataManager.groupIds().forEach(groupId -> {
- long startMs = time.milliseconds();
boolean allOffsetsExpired =
offsetMetadataManager.cleanupExpiredOffsets(groupId, records);
if (allOffsetsExpired) {
groupMetadataManager.maybeDeleteGroup(groupId, records);
}
- log.info("[GroupId {}] Generated {} tombstone records
(allOffsetsExpired={}) in {} milliseconds.",
- groupId, records.size(), allOffsetsExpired,
time.milliseconds() - startMs);
});
+ log.info("Generated {} tombstone records in {} milliseconds.",
records.size(), time.milliseconds() - startMs);
Review Comment:
Should we add a little more context? We don't really know what this log is
about when reading it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
