cmccabe commented on code in PR #14902:
URL: https://github.com/apache/kafka/pull/14902#discussion_r1414698623


##########
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##########
@@ -91,8 +102,15 @@ static class BrokerHeartbeatState {
          */
         private BrokerHeartbeatState next;
 
-        BrokerHeartbeatState(int id) {
+        BrokerHeartbeatState(int id, List<Uuid> directories) {

Review Comment:
   I think we should just require people to pass a list here. It's easy enough 
to pass `Collections.emptyList` if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to