soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1839871090

   @cmccabe thanks for having a look. 
   
   I've made the following changes:
   
   * Replaced the use of `prepend` with `append` in `propagateDirectoryFailure`
   * Moved `communicationInFlight = true` after `_channelManager.sendRequest()`
   * Always set `nextSchedulingShouldBeImmediate = false` in 
`scheduleNextCommunicationAfterFailure`
   * Moved checking if `communicationInFlight = true` to 
`CommunicationEvent.run()`
   
   @junrao @cmccabe: please take another look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to