borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415312775
##########
clients/src/main/java/org/apache/kafka/common/resource/ResourceType.java:
##########
@@ -104,17 +104,18 @@ public static ResourceType fromCode(byte code) {
return resourceType;
}
- private final byte code;
+ //making this int since profiling showed miss alignement.
+ private final int code;
Review Comment:
This improved the performance because the byte was not aligned in memory
resulting in a slow memory access path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
