OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415611267
##########
core/src/main/scala/kafka/log/LogManager.scala:
##########
@@ -123,14 +123,19 @@ class LogManager(logDirs: Seq[File],
}
private val dirLocks = lockLogDirs(liveLogDirs)
- val directoryIds: Map[String, Uuid] = loadDirectoryIds(liveLogDirs)
+ private val directoryIds: mutable.Map[String, Uuid] =
loadDirectoryIds(liveLogDirs)
+ def directoryIdsSet: Predef.Set[Uuid] = directoryIds.values.toSet
+
@volatile private var recoveryPointCheckpoints = liveLogDirs.map(dir =>
(dir, new OffsetCheckpointFile(new File(dir, RecoveryPointCheckpointFile),
logDirFailureChannel))).toMap
@volatile private var logStartOffsetCheckpoints = liveLogDirs.map(dir =>
(dir, new OffsetCheckpointFile(new File(dir,
LogStartOffsetCheckpointFile), logDirFailureChannel))).toMap
private val preferredLogDirs = new ConcurrentHashMap[TopicPartition,
String]()
+ def hasOfflineLogDirs(): Boolean = offlineLogDirs.nonEmpty
Review Comment:
good call fixed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
