clolov commented on code in PR #14929:
URL: https://github.com/apache/kafka/pull/14929#discussion_r1415790106
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##########
@@ -194,19 +206,19 @@ public void shouldNotRegisterSameStoreMultipleTimes() {
@Test
public void shouldNotRegisterStoreWithoutMetadata() {
- EasyMock.replay(stateManager, storeMetadata);
+ EasyMock.replay(storeMetadata);
assertThrows(IllegalStateException.class,
() -> changelogReader.register(new
TopicPartition("ChangelogWithoutStoreMetadata", 0), stateManager));
}
@Test
public void shouldSupportUnregisterChangelogBeforeInitialization() {
+ setupStateManagerMock();
final Map<TaskId, Task> mockTasks = mock(Map.class);
EasyMock.expect(mockTasks.get(null)).andReturn(mock(Task.class)).anyTimes();
EasyMock.expect(storeMetadata.offset()).andReturn(9L).anyTimes();
-
EasyMock.expect(stateManager.changelogOffsets()).andReturn(singletonMap(tp,
10L));
Review Comment:
This (along with other similar expectations) was flagged as unneeded by
Mockito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
