[
https://issues.apache.org/jira/browse/KAFKA-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519833#comment-16519833
]
ASF GitHub Bot commented on KAFKA-5886:
---------------------------------------
yuyang08 opened a new pull request #5270: KAFKA-5886: Introduce
delivery.timeout.ms producer config (KIP-91)
URL: https://github.com/apache/kafka/pull/5270
This change is based on @sutambe 's change
https://github.com/apache/kafka/pull/3849 earlier.
primary changes in this pr:
1. In RecordAccumulator.java, use `inFlightBatches` to track the in-flight
batches, instead of using `soonToExpireInFlightsBatches` to only track the
soon-to-expire batches. With this change, in RecordAccumulator.expiredBatches,
we check both `inFlightBatches` and `batches` to find the expired batches.
2. Fixed the test failures in SenderTest.java and
RecordAccumulatorTest.java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Introduce delivery.timeout.ms producer config (KIP-91)
> ------------------------------------------------------
>
> Key: KAFKA-5886
> URL: https://issues.apache.org/jira/browse/KAFKA-5886
> Project: Kafka
> Issue Type: Improvement
> Components: producer
> Reporter: Sumant Tambe
> Assignee: Sumant Tambe
> Priority: Major
>
> We propose adding a new timeout delivery.timeout.ms. The window of
> enforcement includes batching in the accumulator, retries, and the inflight
> segments of the batch. With this config, the user has a guaranteed upper
> bound on when a record will either get sent, fail or expire from the point
> when send returns. In other words we no longer overload request.timeout.ms to
> act as a weak proxy for accumulator timeout and instead introduce an explicit
> timeout that users can rely on without exposing any internals of the producer
> such as the accumulator.
> See
> [KIP-91|https://cwiki.apache.org/confluence/display/KAFKA/KIP-91+Provide+Intuitive+User+Timeouts+in+The+Producer]
> for more details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
