dajac commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417891269
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return autoCommitState.isPresent() &&
!subscriptions.allConsumed().isEmpty();
}
+ /**
+ * Updates the member ID and epoch upon receiving
ConsumerGroupHeartbeatResponse.
+ */
+ void updateMemberInformation(String memberId, int memberEpoch) {
+ groupState.generation = new GroupState.Generation(memberEpoch,
memberId, null);
+ }
Review Comment:
There are two other places where the member epoch is updated. Should we also
call `updateMemberInformation` for those for completeness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
