lucasbru commented on code in PR #14950:
URL: https://github.com/apache/kafka/pull/14950#discussion_r1419158315
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -61,32 +63,23 @@ public class MembershipManagerImplTest {
private static final String MEMBER_ID = "test-member-1";
private static final int MEMBER_EPOCH = 1;
+ private final LogContext logContext = new LogContext();
private SubscriptionState subscriptionState;
private ConsumerMetadata metadata;
-
private CommitRequestManager commitRequestManager;
- private ConsumerTestBuilder testBuilder;
-
@BeforeEach
public void setup() {
- testBuilder = new
ConsumerTestBuilder(ConsumerTestBuilder.createDefaultGroupInformation());
- metadata = testBuilder.metadata;
- subscriptionState = testBuilder.subscriptions;
- commitRequestManager = testBuilder.commitRequestManager.get();
- }
-
- @AfterEach
- public void tearDown() {
- if (testBuilder != null) {
- testBuilder.close();
- }
+ // The SubscriptionState cannot be mocked, but needs to stay as a spy
as the test relies on its logic.
+ subscriptionState = spy(new SubscriptionState(logContext,
OffsetResetStrategy.EARLIEST));
Review Comment:
Subscription state is mostly a data container. I wonder if we could just
insert and retrieve the expected data instead of injecting it via the spy?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -61,32 +63,23 @@ public class MembershipManagerImplTest {
private static final String MEMBER_ID = "test-member-1";
private static final int MEMBER_EPOCH = 1;
+ private final LogContext logContext = new LogContext();
private SubscriptionState subscriptionState;
private ConsumerMetadata metadata;
-
private CommitRequestManager commitRequestManager;
- private ConsumerTestBuilder testBuilder;
-
@BeforeEach
public void setup() {
- testBuilder = new
ConsumerTestBuilder(ConsumerTestBuilder.createDefaultGroupInformation());
- metadata = testBuilder.metadata;
- subscriptionState = testBuilder.subscriptions;
- commitRequestManager = testBuilder.commitRequestManager.get();
- }
-
- @AfterEach
- public void tearDown() {
- if (testBuilder != null) {
- testBuilder.close();
- }
+ // The SubscriptionState cannot be mocked, but needs to stay as a spy
as the test relies on its logic.
+ subscriptionState = spy(new SubscriptionState(logContext,
OffsetResetStrategy.EARLIEST));
+ metadata = mock(ConsumerMetadata.class);
+ commitRequestManager = mock(CommitRequestManager.class);
}
private MembershipManagerImpl createMembershipManagerJoiningGroup() {
MembershipManagerImpl manager = spy(new MembershipManagerImpl(
Review Comment:
Can we get rid of this spy at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
