philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1419683491


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -178,27 +171,11 @@ static void runAtClose(final Collection<Optional<? 
extends RequestManager>> requ
                            final NetworkClientDelegate networkClientDelegate,
                            final Timer timer) {
         // These are the optional outgoing requests at the
-        List<NetworkClientDelegate.PollResult> pollResults = 
requestManagers.stream()
+        requestManagers.stream()

Review Comment:
   see the comment in the FetchRequestManager



##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -178,27 +171,11 @@ static void runAtClose(final Collection<Optional<? 
extends RequestManager>> requ
                            final NetworkClientDelegate networkClientDelegate,
                            final Timer timer) {
         // These are the optional outgoing requests at the
-        List<NetworkClientDelegate.PollResult> pollResults = 
requestManagers.stream()
+        requestManagers.stream()

Review Comment:
   @kirktrue 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to