jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1419756648
##########
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala:
##########
@@ -168,8 +168,37 @@ object AbstractCoordinatorConcurrencyTest {
watchKeys = Collections.newSetFromMap(new
ConcurrentHashMap[TopicPartitionOperationKey, java.lang.Boolean]()).asScala
}
+ override def maybeStartTransactionVerificationForPartition(
+ topicPartition: TopicPartition,
+ transactionalId: String,
+ producerId: Long,
+ producerEpoch: Short,
+ baseSequence: Int,
+ requestLocal: RequestLocal,
+ callback: (Errors, RequestLocal, VerificationGuard) => Unit
+ ): Unit = {
+ // Skip verification
+ callback(Errors.NONE, requestLocal, VerificationGuard.SENTINEL)
+ }
+
override def tryCompleteActions(): Unit =
watchKeys.map(producePurgatory.checkAndComplete)
+ override def appendForGroup(timeout: Long,
+ requiredAcks: Short,
+ internalTopicsAllowed: Boolean,
+ origin: AppendOrigin,
+ entriesPerPartition: Map[TopicPartition,
MemoryRecords],
+ responseCallback: Map[TopicPartition,
PartitionResponse] => Unit,
+ delayedProduceLock: Option[Lock] = None,
+ recordValidationStatsCallback:
Map[TopicPartition, RecordValidationStats] => Unit = _ => (),
+ requestLocal: RequestLocal =
RequestLocal.NoCaching,
+ actionQueue: ActionQueue = null,
+ verificationGuards: Map[TopicPartition,
VerificationGuard] = Map.empty,
Review Comment:
when we get to the log layer if we don't have an entry in the map we do a
getOrElse and return the sentinel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
