mimaison commented on code in PR #13662:
URL: https://github.com/apache/kafka/pull/13662#discussion_r1420500562
##########
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##########
@@ -143,7 +143,7 @@ public class JsonConverter implements Converter,
HeaderConverter, Versioned {
// names specified in the field
private static final HashMap<String, LogicalTypeConverter>
LOGICAL_CONVERTERS = new HashMap<>();
- private static final JsonNodeFactory JSON_NODE_FACTORY =
JsonNodeFactory.withExactBigDecimals(true);
+ private static final JsonNodeFactory JSON_NODE_FACTORY = new
JsonNodeFactory(true);
Review Comment:
Can you clarify why we're making this changes?
##########
LICENSE-binary:
##########
@@ -216,16 +216,16 @@ commons-lang3-3.8.1
commons-logging-1.2
commons-validator-1.7
error_prone_annotations-2.10.0
-jackson-annotations-2.13.5
-jackson-core-2.13.5
-jackson-databind-2.13.5
-jackson-dataformat-csv-2.13.5
-jackson-datatype-jdk8-2.13.5
-jackson-jaxrs-base-2.13.5
-jackson-jaxrs-json-provider-2.13.5
-jackson-module-jaxb-annotations-2.13.5
-jackson-module-scala_2.13-2.13.5
-jackson-module-scala_2.12-2.13.5
+jackson-annotations-2.15.3
Review Comment:
There's even a 2.16.0 release now. Is there a reason you picked 2.15.3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
